Bug #690
Static Sidebar admin interface doesn't change Title (rails_1_1 branch)
| Status : | Closed | Start : | ||
| Priority : | Normal | Due date : | ||
| Assigned to : | tobi - | % Done : | 0% |
|
| Category : | admin | |||
| Target version : | 4.1 | |||
| Resolution : | fixed |
Description
This is in the rails_1_1 branch, revision 973.
When attempting to change the 'Title' field of a Static Sidebar, the change is not made. The body html content is updated without error. No errors are logged.
Here is the development.log excerpt, I have snipped out most of the body content for conciseness:# Logfile created on Thu Mar 30 09:36:20 CST 2006 by logger.rb/1.5.2.7 Processing SidebarController#publish (for 198.209.26.252 at 2006-03-30 09:36:21) [POST] Session ID: c3b262301df74e64c9d9021848b4a5fa Parameters: {"action"=>"publish", "configure"=>{"format"=>"rss20", "body"=>"<ul>\n<li> ***All my html*** </li>\n</ul>\n", "title"=>"Friends", "comments"=>"on", "articles"=>"on"}, "controller"=>"admin/sidebar"} Blog Load (0.000400) SELECT * FROM blogs ORDER BY id LIMIT 1 SQL (0.000365) SELECT version FROM schema_info SQL (0.000158) BEGIN Sidebar Load (0.000461) SELECT * FROM sidebars Sidebar Columns (0.000293) SHOW FIELDS FROM sidebars Sidebar Update (0.000535) UPDATE sidebars SET @controller@ = 'static', @active_position@ = 0, @staged_position@ = 0, @staged_config@ = '--- !map:HashWithIndifferentAccess \nbody: |\n <ul>\n <li> ***All my html*** </li>\n </ul>\n\n', @active_config@ = '--- !map:HashWithIndifferentAccess \nbody: |\n <ul>\n <li> ***ALL my html*** </li>\n </ul>\n\n' WHERE id = 4 Sidebar Update (0.000477) UPDATE sidebars SET @controller@ = 'xml', @active_position@ = 1, @staged_position@ = 1, @staged_config@ = '--- \ntrackbacks: false\nformat: rss20\ncomments: true\narticles: true\n', @active_config@ = '--- \ntrackbacks: false\nformat: rss20\ncomments: true\narticles: true\n' WHERE id = 5 Sidebar Delete all (0.000341) DELETE FROM sidebars WHERE (active_position is null and staged_position is null) SQL (0.000231) COMMIT Rendered admin/sidebar/_publish (0.00145) Completed in 0.03880 (25 reqs/sec) | Rendering: 0.00232 (5%) | DB: 0.00326 (8%) | 200 OK [http://1jiveturkey.com/typo/admin/sidebar/publish]
Version info:
Path: . URL: svn://typosphere.org/typo/branches/rails_1_1 Repository UUID: 820eb932-12ee-0310-9ca8-eeb645f39767 Revision: 973 Node Kind: directory Schedule: normal Last Changed Author: pdcawley Last Changed Rev: 973 Last Changed Date: 2006-03-30 01:58:09 -0600 (Thu, 30 Mar 2006) Properties Last Updated: 2006-03-30 08:48:34 -0600 (Thu, 30 Mar 2006)
History
03/30/2006 04:14 PM - pdcawley -
Argh! (And this applies to all the sidebar stuff)
It seems that the various configurations in the sidebar admin are updated using
observe_form. And
observe_form, without a timeout, only triggers when a field 'blurs', which is to say when you tab from one field to the next, or click outside the form before clicking on save changes.
The fix for this is going to be somewhat complicated I'm afraid. For now, the workaround is to click somewhere outside the form, wait a couple of seconds, and then click 'publish changes'. As far as I can tell, this has been an issue since forever, at least in some browsers.
One more reason to entirely rework the way sidebars work I think.
I'm pushing this to milestone 4.1, but could be persuaded to pull it back to 4.0 if people squawk.
03/30/2006 04:25 PM - chrismc-ozarkmountain-net -
I'd be completely happy with a workaround for now, but I can't get that to work. I tried it in both Firefox and IE7. Anything obvious I may be missing?
03/31/2006 03:56 AM - pdcawley -
Probably something obvious that I'm missing I'm afraid. Continuing my 'voodoo' approach, you could try tabbing out of the title box, which should definitely trigger an onBlur event, which should definitely trigger sending the form contents back to the server.
Or I could just go and fix the damned code.