Bug #92

Frontpage caching broken again

Added by scoop - 1223 days ago. Updated 617 days ago.

Status :Closed Start :
Priority :High Due date :
Assigned to :tobi - % Done :

0%
Category :frontend
Target version :2.5
Resolution :

fixed

Description

Now that pagination uses /articles/pageX instead of ?page= frontpage caching is broken again. If the cache is swept and someone accesses a page beyond 1, this will be stored as the frontpage index page.

Associated revisions

Revision 0c47b414423c7d83e746e25ae5aea86b0893a144
Added by scoop 1240 days ago

  • De-tabbed ArticleHelper#render_errors * Added content-type header to Admin::ContentController#preview fixing rendering of special characters (fixes #92)

git-svn-id: http://svn.typosphere.org/typo/trunk@305 820eb932-12ee-0310-9ca8-eeb645f39767

History

07/27/2005 11:33 AM - scoop -

  • Status changed from New to Closed
  • Resolution set to fixed

(In r462) Exclude pages with page\d+ in their path from being cached (temporarily closes #234, any other takes?)

07/27/2005 11:56 AM - scoop -

  • Status changed from Closed to Feedback
  • Resolution deleted (fixed)

07/27/2005 11:59 AM - scoop -

It should be investigated why the page cache still stores things in public/index.html even if the accessed path is something like yourblog/articles/page2

07/27/2005 03:00 PM - Redmine Admin

the unless path =~ /\?\w+/ part doesn't seem to have an effect here...

07/27/2005 08:47 PM - Redmine Admin

caching_pages_fix.diff seems to really do what it says here...

It also replaces the /pageNN routes by /page/NN ones.
There is still some code in application.rb in self.cache_page that I didn't remove, but I think it's not useful anymore.

07/27/2005 10:04 PM - Damien Pollet -

Okay, I slightly goofed on this one... apply caching_pages_fix.diff and caching_pages_fix_more.2.diff (and please forget about caching_pages_fix_more.diff...)

These should fix the pages vs. cache problem.

07/28/2005 01:23 PM - tobi -

  • Status changed from Feedback to Closed
  • Resolution set to fixed

(In r466) fixes frontpage caching regression which would overwrite the index.html with an old version with specially crafted urls (Damien Pollet) closes #234

Also available in: Atom PDF