Bug #348

[PATCH] Fix uniqueness of ids in sidebar config

Added by Redmine Admin 1224 days ago. Updated 790 days ago.

Status :Closed Start :
Priority :Normal Due date :
Assigned to :tobi - % Done :

0%
Category :admin
Target version :2.5
Resolution :

fixed

Description

r449 fixed one validation issue, but it introduced another - the ids used for the configuration controls are not unique. The attached patch inserts the sidebar plugin's id into the control ids to make then unique.

Associated revisions

Revision 7fe8c141b80b0ac31095f674061b7ea8188aed4d
Added by scoop 1191 days ago

Also escape special characters in title attribute of feed collected sidebar items (closes #348 yet again)

git-svn-id: http://svn.typosphere.org/typo/trunk@586 820eb932-12ee-0310-9ca8-eeb645f39767

Revision b259d2a12f842c065542efd64439a860ecbc51a5
Added by scoop 1195 days ago

Escape special characters in feed collected items when displayed in sidebar (closes #348) -- did I mention sidebars need tests badly?

git-svn-id: http://svn.typosphere.org/typo/trunk@562 820eb932-12ee-0310-9ca8-eeb645f39767

History

07/26/2005 06:15 PM - scott -

Wouldn't it be easier to just remove the id from these <input>s entirely? Nothing actually uses them, and none of the original sidebar plugins use ids on their config forms (for just this reason).

07/26/2005 07:45 PM - scoop -

  • Status changed from New to Closed
  • Resolution set to fixed
(In r456)
  • Fixed uniqueness of ids in sidebar config (closes #224) []
  • Added required "action" attribute to dummy form on sidebar admin so it passes validation

Also available in: Atom PDF