I neglected to mention that the patch also makes the "categories" section toggle like the "extended content" or "advanced options" sections.

Ok, this is an interesting patch, but I personally think the end result isn't very pretty or usable. If I want autotagging I want it to prune the tag list to only what matches the typed text, not show a list of every single tag and select the first matching one. That really isn't all that useful to me, especially if I have a huge number of tags. If you can rework it a bit to be more usable I'll look at it again.

I will return this to a "matching typed" only setup. Simple enough that is what Autocompleter.Local does by default. As for pretty? Could you maybe describe what you would like to see? I thought the blue stripe that matched the admin insterface was "man-pretty" at least :-)

I will also add the number of articles tagged in parens after the tag name to enhance usablility. I meant to do that from the start. I may also look at positioning the box under the first character you are typing if I can figure out the JS font-size to pixel conversion factor. I read somewhere it is 1 to 16 for em, patch to follow...

Okay! I went back to matching on the characters typed. I added the number of articles the tag is associated with in parenthesis after the tag name in the drop down. An exciting border was added to improve the "look" :-) I also added a migration and configuration chunk on the admin/general settings tab so that a user can configure 1) whether or not they want auto tagging on, and 2)the numerical limit on the number of tags displayed in the auto tagger. I also put the JS back onto the form partial as it seems unlikely to be reused anywhere else in the interface. I put the categories section back the way it was because I sensed that might upset some people. (Also now tested to work in IE!)

Ok, I just tested this against r946 and even with the hacking on content_controller it doesn't seem to be working.

Oh, and your migration 40 to add fields to the blog table was completely unnecessary. Settings are saved in a serialized field.

In any case, I'm pulling this off of 4.0 (should never have been assigned a milestone in the first place), and if you submit another patch that works with HEAD I'll try it again.

patched against 946. Moved content controller code around. I added "(autocomplete: enabled/disabled)" next to the Keywords field on admin article _form.rhtml so you can tell the status of the setting. Removed the migration from the patch. Looks like my lighty conf file got included by mistake, disregard it. CWD is necassary to run on lighty 1.4.11+

Patch have been lost in a old trac migration. Closing.

Test Trac email again. seduction pickup

Milestone 4.2 deleted